netdev - [PATCH] net: netfilter: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1512459249-857-1-git-send-email-xiaolou4617@gmail.com>
Date:   Tue,  5 Dec 2017 15:34:09 +0800
From:   Lin Zhang <xiaolou4617@...il.com>
To:     pablo@...filter.org, kadlec@...ckhole.kfki.hu, fw@...len.de,
        davem@...emloft.net
Cc:     netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, Lin Zhang <xiaolou4617@...il.com>
Subject: [PATCH] net: netfilter: fix coding style

I think use variable 'min' instead of number '1024' is better.

Signed-off-by: Lin Zhang <xiaolou4617@...il.com>
---
 net/netfilter/nf_nat_proto_common.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/nf_nat_proto_common.c b/net/netfilter/nf_nat_proto_common.c
index fbce552..e87e683 100644
--- a/net/netfilter/nf_nat_proto_common.c
+++ b/net/netfilter/nf_nat_proto_common.c
@@ -67,7 +67,7 @@ void nf_nat_l4proto_unique_tuple(const struct nf_nat_l3proto *l3proto,
 			}
 		} else {
 			min = 1024;
-			range_size = 65535 - 1024 + 1;
+			range_size = 65535 - min + 1;
 		}
 	} else {
 		min = ntohs(range->min_proto.all);
-- 
1.7.1