netdev - Re: [PATCH] VSOCK: fix outdated sk_state value in hvs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6988759A-BB1B-4861-B6AE-881D8C767927@vmware.com>
Date:   Tue, 5 Dec 2017 13:31:26 +0000
From:   "Jorgen S. Hansen" <jhansen@...are.com>
To:     Stefan Hajnoczi <stefanha@...hat.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Dexuan Cui <decui@...rosoft.com>,
        Cathy Avery <cavery@...hat.com>
Subject: Re: [PATCH] VSOCK: fix outdated sk_state value in hvs_release()


> On Dec 5, 2017, at 12:31 PM, Stefan Hajnoczi <stefanha@...hat.com> wrote:
> 
> Since commit 3b4477d2dcf2709d0be89e2a8dced3d0f4a017f2 ("VSOCK: use TCP
> state constants for sk_state") VSOCK has used TCP_* constants for
> sk_state.
> 
> Commit b4562ca7925a3bedada87a3dd072dd5bad043288 ("hv_sock: add locking
> in the open/close/release code paths") reintroduced the SS_DISCONNECTING
> constant.
> 
> This patch replaces the old SS_DISCONNECTING with the new TCP_CLOSING
> constant.
> 
> CC: Dexuan Cui <decui@...rosoft.com>
> CC: Cathy Avery <cavery@...hat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@...hat.com>
> ---
> net/vmw_vsock/hyperv_transport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c
> index 5583df708b8c..a827547aa102 100644
> --- a/net/vmw_vsock/hyperv_transport.c
> +++ b/net/vmw_vsock/hyperv_transport.c
> @@ -487,7 +487,7 @@ static void hvs_release(struct vsock_sock *vsk)
> 
> 	lock_sock(sk);
> 
> -	sk->sk_state = SS_DISCONNECTING;
> +	sk->sk_state = TCP_CLOSING;
> 	vsock_remove_sock(vsk);
> 
> 	release_sock(sk);
> -- 
> 2.14.3
> 

Reviewed-by: Jorgen Hansen <jhansen@...are.com>