netdev - Re: [PATCH net] tcp: use current time in tcp_rcv_space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171206.155445.658202184783975963.davem@davemloft.net>
Date:   Wed, 06 Dec 2017 15:54:45 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, weiwan@...gle.com, ncardwell@...gle.com,
        ycheng@...gle.com
Subject: Re: [PATCH net] tcp: use current time in tcp_rcv_space_adjust()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 06 Dec 2017 11:08:19 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> When I switched rcv_rtt_est to high resolution timestamps, I forgot
> that tp->tcp_mstamp needed to be refreshed in tcp_rcv_space_adjust()
> 
> Using an old timestamp leads to autotuning lags.
> 
> Fixes: 645f4c6f2ebd ("tcp: switch rcv_rtt_est and rcvq_space to high resolution timestamps")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks Eric.