netdev - Re: [PATCH] usbnet: fix alignment for frames with no ethernet header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171206.155611.1757498962538253791.davem@davemloft.net>
Date:   Wed, 06 Dec 2017 15:56:11 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     bjorn@...k.no
Cc:     netdev@...r.kernel.org, jay@...tech.com, linux-usb@...r.kernel.org,
        oneukum@...e.com
Subject: Re: [PATCH] usbnet: fix alignment for frames with no ethernet
 header

From: Bjørn Mork <bjorn@...k.no>
Date: Wed,  6 Dec 2017 20:21:24 +0100

> The qmi_wwan minidriver support a 'raw-ip' mode where frames are
> received without any ethernet header. This causes alignment issues
> because the skbs allocated by usbnet are "IP aligned".
> 
> Fix by allowing minidrivers to disable the additional alignment
> offset. This is implemented using a per-device flag, since the same
> minidriver also supports 'ethernet' mode.
> 
> Fixes: 32f7adf633b9 ("net: qmi_wwan: support "raw IP" mode")
> Reported-and-tested-by: Jay Foster <jay@...tech.com>
> Signed-off-by: Bjørn Mork <bjorn@...k.no>

Looks good, applied and queued up for -stable.