netdev - Re: [PATCH net] sfc: pass valid pointers from efx_enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a3c0588-dbe3-e129-7055-de0ece332fc9@redhat.com>
Date:   Fri, 8 Dec 2017 10:37:00 -0500
From:   Jarod Wilson <jarod@...hat.com>
To:     Bert Kenward <bkenward@...arflare.com>,
        Dave Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH net] sfc: pass valid pointers from efx_enqueue_unwind

On 2017-12-07 12:18 PM, Bert Kenward wrote:
> The bytes_compl and pkts_compl pointers passed to efx_dequeue_buffers
> cannot be NULL. Add a paranoid warning to check this condition and fix
> the one case where they were NULL.
> 
> efx_enqueue_unwind() is called very rarely, during error handling.
> Without this fix it would fail with a NULL pointer dereference in
> efx_dequeue_buffer, with efx_enqueue_skb in the call stack.
> 
> Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2")
> Reported-by: Jarod Wilson <jarod@...hat.com>
> Signed-off-by: Bert Kenward <bkenward@...arflare.com>

I didn't have the warn, but the rest is identical to what I did locally 
to get around this when I was hitting it.

Tested-by: Jarod Wilson <jarod@...hat.com>
Acked-by: Jarod Wilson <jarod@...hat.com>

-- 
Jarod Wilson
jarod@...hat.com