netdev - Re: [PATCH net] sfc: pass valid pointers from efx_enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171208.132651.960123172558789563.davem@davemloft.net>
Date:   Fri, 08 Dec 2017 13:26:51 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     bkenward@...arflare.com
Cc:     netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
        jarod@...hat.com
Subject: Re: [PATCH net] sfc: pass valid pointers from efx_enqueue_unwind

From: Bert Kenward <bkenward@...arflare.com>
Date: Thu, 7 Dec 2017 17:18:58 +0000

> The bytes_compl and pkts_compl pointers passed to efx_dequeue_buffers
> cannot be NULL. Add a paranoid warning to check this condition and fix
> the one case where they were NULL.
> 
> efx_enqueue_unwind() is called very rarely, during error handling.
> Without this fix it would fail with a NULL pointer dereference in
> efx_dequeue_buffer, with efx_enqueue_skb in the call stack.
> 
> Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2")
> Reported-by: Jarod Wilson <jarod@...hat.com>
> Signed-off-by: Bert Kenward <bkenward@...arflare.com>

Applied and queued up for -stable, thanks.