netdev - Re: [PATCH net-next v2 5/6] net: qualcomm: rmnet: Allow to configure flags for new devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171211.121852.804410408823633381.davem@davemloft.net>
Date:   Mon, 11 Dec 2017 12:18:52 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     subashab@...eaurora.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 5/6] net: qualcomm: rmnet: Allow to
 configure flags for new devices

From: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Date: Sat,  9 Dec 2017 13:58:29 -0700

> @@ -312,7 +321,8 @@ static int rmnet_rtnl_validate(struct nlattr *tb[], struct nlattr *data[],
>  
>  static size_t rmnet_get_size(const struct net_device *dev)
>  {
> -	return nla_total_size(2); /* IFLA_VLAN_ID */
> +	return nla_total_size(2) /* IFLA_VLAN_ID */ +
> +	nla_total_size(sizeof(struct ifla_vlan_flags)); /* IFLA_VLAN_FLAGS */
>  }
>  

Please indent this return statement properly, the second line of the
expression definitely should not start at the same column as the
'return'.

Thank you.