netdev - Re: [PATCH V2] netlink: Add netns check on taps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171211172256.lni62talvtvqwrdb@unicorn.suse.cz>
Date:   Mon, 11 Dec 2017 18:22:56 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     David Miller <davem@...emloft.net>
Cc:     cernekee@...omium.org, johannes.berg@...el.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        daniel@...earbox.net, dsahern@...il.com
Subject: Re: [PATCH V2] netlink: Add netns check on taps

On Mon, Dec 11, 2017 at 11:58:37AM -0500, David Miller wrote:
> From: Michal Kubecek <mkubecek@...e.cz>
> Date: Mon, 11 Dec 2017 17:13:50 +0100
> 
> > On Wed, Dec 06, 2017 at 03:57:14PM -0500, David Miller wrote:
> >> From: Kevin Cernekee <cernekee@...omium.org>
> >> Date: Wed,  6 Dec 2017 12:12:27 -0800
> >> 
> >> > Currently, a nlmon link inside a child namespace can observe systemwide
> >> > netlink activity.  Filter the traffic so that nlmon can only sniff
> >> > netlink messages from its own netns.
> >> > 
> >> > Test case:
> >> > 
> >> >     vpnns -- bash -c "ip link add nlmon0 type nlmon; \
> >> >                       ip link set nlmon0 up; \
> >> >                       tcpdump -i nlmon0 -q -w /tmp/nlmon.pcap -U" &
> >> >     sudo ip xfrm state add src 10.1.1.1 dst 10.1.1.2 proto esp \
> >> >         spi 0x1 mode transport \
> >> >         auth sha1 0x6162633132330000000000000000000000000000 \
> >> >         enc aes 0x00000000000000000000000000000000
> >> >     grep --binary abc123 /tmp/nlmon.pcap
> >> > 
> >> > Signed-off-by: Kevin Cernekee <cernekee@...omium.org>
> >> 
> >> Applied and queued up for -stable, thanks Kevin.
> > 
> > David,
> > 
> > this patch is marked as accepted in patchworks and listed in
> > 
> >   http://patchwork.ozlabs.org/bundle/davem/stable/?state=*
> > 
> > but it's not in the net tree. Is there a problem with it?
> 
> Sorry, it should be there now.

Thank you,

Michal Kubecek