netdev - Re: [PATCH net] tcp: fix potential underestimation on rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171213.160336.2021377396736438041.davem@davemloft.net>
Date:   Wed, 13 Dec 2017 16:03:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     weiwan@...gle.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net] tcp: fix potential underestimation on rcv_rtt

From: Wei Wang <weiwan@...gle.com>
Date: Tue, 12 Dec 2017 16:28:58 -0800

> From: Wei Wang <weiwan@...gle.com>
> 
> When ms timestamp is used, current logic uses 1us in
> tcp_rcv_rtt_update() when the real rcv_rtt is within 1 - 999us.
> This could cause rcv_rtt underestimation.
> Fix it by always using a min value of 1ms if ms timestamp is used.
> 
> Fixes: 645f4c6f2ebd ("tcp: switch rcv_rtt_est and rcvq_space to high
> resolution timestamps")
> 
> Signed-off-by: Wei Wang <weiwan@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Please, in the future, do not wrap long Fixes: tag lines.  Also, do
not add an empty line between Fixes: and other tags like Signed-off-by.
That are all tags and belong together as a seamless block of text.

Thank you.