netdev - Re: net: phy: consolidate PHY reset in phy_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f073b5c5-8e87-a910-439b-06a758e53d22@cisco.com>
Date:   Wed, 13 Dec 2017 13:03:47 -0800
From:   Daniel Walker <danielwa@...co.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: net: phy: consolidate PHY reset in phy_init_hw()

On 12/13/2017 12:35 PM, Andrew Lunn wrote:
> On Wed, Dec 13, 2017 at 10:46:02AM -0800, Daniel Walker wrote:
>> Hi,
>>
>> https://sjc-apl-grt32.cisco.com:8081/gitweb?p=xe-linux/kernel.git;a=commit;h=87aa9f9c61ad56d505641681812e92ad976f8608
> Hi Daniel
>
> This is a 4 year old patch, so i'm kind of surprised nobody noticed
> this before. How did you conclude this patch is the problem?
>
>       Thanks
> 	Andrew

I just did some debugging to find the -ETIMEDOUT error message which I 
tracked back to the waiting routine inside this patch. I did do a high 
level bisect jumping between major versions, and the issue seemed to go 
away around the time when this patch was added. v3.10 didn't have it, 
and one of the version of the kernel immediately after had it, either 
v3.11 or v3.12 ..

This phy may not be used often, that might be part of it.

Daniel