netdev - Re: [PATCH net] tcp: refresh tcp_mstamp from timers callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171213.160447.126875023972302023.davem@davemloft.net>
Date:   Wed, 13 Dec 2017 16:04:47 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, soheil@...gle.com, ncardwell@...gle.com,
        maloney@...gle.com
Subject: Re: [PATCH net] tcp: refresh tcp_mstamp from timers callbacks

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 12 Dec 2017 18:22:52 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Only the retransmit timer currently refreshes tcp_mstamp
> 
> We should do the same for delayed acks and keepalives.
> 
> Even if RFC 7323 does not request it, this is consistent to what linux
> did in the past, when TS values were based on jiffies.
> 
> Fixes: 385e20706fac ("tcp: use tp->tcp_mstamp in output path")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks Eric.