netdev - [BUG] b44: two possible sleep-in-atomic bugs in b44_set_link_ksettings and b44

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5299283f-95e6-61b5-267c-5e12ca72fe41@gmail.com>
Date:   Wed, 13 Dec 2017 11:29:46 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     michael.chan@...adcom.com, hauke@...ke-m.de,
        David Miller <davem@...emloft.net>, f.fainelli@...il.com,
        opendmb@...il.com, sathya.perla@...adcom.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [BUG] b44: two possible sleep-in-atomic bugs in
 b44_set_link_ksettings and b44_ioctl

The driver may sleep under a spinlock.
The function call paths are:
b44_set_link_ksettings (acquire the spinlock)
   phy_ethtool_ksettings_set
     phy_start_aneg
       phy_start_aneg_priv
         mutex_lock --> may sleep

b44_ioctl (acquire the spinlock)
   phy_mii_ioctl
     mdiobus_read
       mutex_lock --> may sleep

I do not find a good way to fix them, so I only report.
These possible bugs are found by my static analysis tool (DSAC) and 
checked by my code review.


Thanks,
Jia-Ju Bai