netdev - [BUG] renesas/sh_eth: two possible sleep-in-atomic bugs in sh_eth_set_link_ksettings and sh_eth_nway

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <45698118-3050-d1c5-4e48-c318d0cd164d@gmail.com>
Date:   Wed, 13 Dec 2017 11:39:07 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     sergei.shtylyov@...entembedded.com, davem@...emloft.net,
        niklas.soderlund+renesas@...natech.se, geert+renesas@...der.be,
        laurent.pinchart@...asonboard.com, horms+renesas@...ge.net.au
Cc:     netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [BUG] renesas/sh_eth: two possible sleep-in-atomic bugs in
 sh_eth_set_link_ksettings and sh_eth_nway_reset

Accoring to drivers/net/ethernet/renesas/sh_eth.c, the driver may sleep 
under a spinlock.
The function call paths are:
sh_eth_set_link_ksettings (acquire the spinlock)
   phy_ethtool_ksettings_set
     phy_start_aneg
       phy_start_aneg_priv
         mutex_lock --> may sleep

sh_eth_nway_reset (acquire the spinlock)
   phy_start_aneg
     phy_start_aneg_priv
       mutex_lock --> may sleep

I do not find a good way to fix them, so I only report.
These possible bugs are found by my static analysis tool (DSAC) and 
checked by my code review.


Thanks,
Jia-Ju Bai