netdev - Re: [PATCH iproute2 1/1] ss: add missing path MTU parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQynM6HX-q-ZA=XiGEcOjU6U5LyVxTqkcE87Vbfoo2mrf-g@mail.gmail.com>
Date:   Thu, 14 Dec 2017 14:32:00 -0500
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Roman Mashak <mrv@...atatu.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Netdev <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH iproute2 1/1] ss: add missing path MTU parameter

On Thu, Dec 14, 2017 at 2:23 PM, Roman Mashak <mrv@...atatu.com> wrote:
>
> Signed-off-by: Roman Mashak <mrv@...atatu.com>
> ---
...
> @@ -1967,6 +1968,8 @@ static void tcp_stats_print(struct tcpstat *s)
>                 printf(" cwnd:%u", s->cwnd);
>         if (s->ssthresh)
>                 printf(" ssthresh:%d", s->ssthresh);
> +       if (s->pmtu)
> +               printf(" pmtu:%u", s->pmtu);

Would it be possible to print the pmtu immediately after the mss? IMHO
having related parameters next to each other this way would make this
easier to parse for humans.

Thanks for adding this!

cheers,
neal