netdev - Re: [PATCH iproute2 1/1] ss: add missing path MTU parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85k1xpulys.fsf@mojatatu.com>
Date:   Thu, 14 Dec 2017 14:51:39 -0500
From:   Roman Mashak <mrv@...atatu.com>
To:     Neal Cardwell <ncardwell@...gle.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Netdev <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH iproute2 1/1] ss: add missing path MTU parameter

Neal Cardwell <ncardwell@...gle.com> writes:

> On Thu, Dec 14, 2017 at 2:23 PM, Roman Mashak <mrv@...atatu.com> wrote:
>>
>> Signed-off-by: Roman Mashak <mrv@...atatu.com>
>> ---
> ...
>> @@ -1967,6 +1968,8 @@ static void tcp_stats_print(struct tcpstat *s)
>>                 printf(" cwnd:%u", s->cwnd);
>>         if (s->ssthresh)
>>                 printf(" ssthresh:%d", s->ssthresh);
>> +       if (s->pmtu)
>> +               printf(" pmtu:%u", s->pmtu);
>
> Would it be possible to print the pmtu immediately after the mss? IMHO
> having related parameters next to each other this way would make this
> easier to parse for humans.
>
> Thanks for adding this!

Sure, I will send v2 with change.