netdev - Re: [PATCHv2 net-next 03/15] net: sched: sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa395eb8-0c7f-17ea-0ce4-d33290c25a52@gmail.com>
Date:   Thu, 14 Dec 2017 12:56:38 -0700
From:   David Ahern <dsahern@...il.com>
To:     Alexander Aring <aring@...atatu.com>, jhs@...atatu.com
Cc:     xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
        netdev@...r.kernel.org, kernel@...atatu.com,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCHv2 net-next 03/15] net: sched: sch_api: handle generic
 qdisc errors

On 12/14/17 11:38 AM, Alexander Aring wrote:
> @@ -912,8 +920,10 @@ static int qdisc_graft(struct net_device *dev, struct Qdisc *parent,
>  		    (new && new->flags & TCQ_F_INGRESS)) {
>  			num_q = 1;
>  			ingress = 1;
> -			if (!dev_ingress_queue(dev))
> +			if (!dev_ingress_queue(dev)) {
> +				NL_SET_ERR_MSG(extack, "Cannot find ingress queue for specified device");

"Device does not have an ingress queue" ?


> @@ -1241,8 +1262,10 @@ static int tc_get_qdisc(struct sk_buff *skb, struct nlmsghdr *n,
>  	int err;
>  
>  	if ((n->nlmsg_type != RTM_GETQDISC) &&
> -	    !netlink_ns_capable(skb, net->user_ns, CAP_NET_ADMIN))
> +	    !netlink_ns_capable(skb, net->user_ns, CAP_NET_ADMIN)) {
> +		NL_SET_ERR_MSG(extack, "Net admin permission required for this operation");

EPERM does not need a string.



> @@ -1309,8 +1346,10 @@ static int tc_modify_qdisc(struct sk_buff *skb, struct nlmsghdr *n,
>  	struct Qdisc *q, *p;
>  	int err;
>  
> -	if (!netlink_ns_capable(skb, net->user_ns, CAP_NET_ADMIN))
> +	if (!netlink_ns_capable(skb, net->user_ns, CAP_NET_ADMIN)) {
> +		NL_SET_ERR_MSG(extack, "Net admin permission required for this operation");

Ditto here. Please check other patches as well.

>  		return -EPERM;
> +	}
>  
>  replay:
>  	/* Reinit, just in case something touches this. */