[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5f5dec26-3c2a-f101-4eae-76aa3ca9e9a5@iogearbox.net>
Date: Thu, 14 Dec 2017 13:45:24 +0100
From: Daniel Borkmann <daniel@...earbox.net>
To: Roman Gushchin <guro@...com>, netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, kernel-team@...com, ast@...nel.org,
jakub.kicinski@...ronome.com, kafai@...com,
Quentin Monnet <quentin.monnet@...ronome.com>,
David Ahern <dsahern@...il.com>
Subject: Re: [PATCH v4 net-next 0/4] bpftool: cgroup bpf operations
On 12/13/2017 04:18 PM, Roman Gushchin wrote:
> This patchset adds basic cgroup bpf operations to bpftool.
>
> Right now there is no convenient way to perform these operations.
> The /samples/bpf/load_sock_ops.c implements attach/detacg operations,
> but only for BPF_CGROUP_SOCK_OPS programs. Bps (part of bcc) implements
> bpf introspection, but lacks any cgroup-related specific.
>
> I find having a tool to perform these basic operations in the kernel tree
> very useful, as it can be used in the corresponding bpf documentation
> without creating additional dependencies. And bpftool seems to be
> a right tool to extend with such functionality.
>
> v4:
> - ATTACH_FLAGS and ATTACH_TYPE are listed and described in docs and usage
> - ATTACH_FLAG names converted to "multi" and "override"
> - do_attach() recognizes ATTACH_FLAG abbreviations, e.g "mul"
> - Local variables sorted ("reverse Christmas tree")
> - unknown attach flags value will be never truncated
Series applied to bpf-next, thanks everyone!
Powered by blists - more mailing lists