netdev - Re: [PATCH] qed: Remove unused QED_RDMA_DEV_CAP_* symbols and dev->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171218.151354.978438255508508144.davem@davemloft.net>
Date:   Mon, 18 Dec 2017 15:13:54 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     helgaas@...nel.org
Cc:     netdev@...r.kernel.org, linux-pci@...r.kernel.org,
        Ariel.Elior@...ium.com, everest-linux-l2@...ium.com
Subject: Re: [PATCH] qed: Remove unused QED_RDMA_DEV_CAP_* symbols and
 dev->dev_caps

From: Bjorn Helgaas <helgaas@...nel.org>
Date: Fri, 15 Dec 2017 17:03:01 -0600

> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> The QED_RDMA_DEV_CAP_* symbols are only used to set bits in dev->dev_caps.
> Nobody ever looks at those bits.  Remove the symbols and dev_caps itself.
> 
> Note that if these are ever used and added back, it looks incorrect to set
> QED_RDMA_DEV_CAP_ATOMIC_OP based on PCI_EXP_DEVCTL2_LTR_EN.  LTR is the
> Latency Tolerance Reporting mechanism, which has nothing to do with Atomic
> Ops.
> 
> No functional change intended.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Applied to net-next.