netdev - Re: [PATCH net] net: always reevalulate autoflowlabel setting for reset packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171219.141533.1790109391093303587.davem@davemloft.net>
Date:   Tue, 19 Dec 2017 14:15:33 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     shli@...nel.org
Cc:     netdev@...r.kernel.org, Kernel-team@...com, shli@...com,
        kafai@...com
Subject: Re: [PATCH net] net: always reevalulate autoflowlabel setting for
 reset packet

From: Shaohua Li <shli@...nel.org>
Date: Mon, 18 Dec 2017 18:58:25 -0800

> @@ -789,7 +789,9 @@ static void tcp_v6_send_response(const struct sock *sk, struct sk_buff *skb, u32
>  	unsigned int tot_len = sizeof(struct tcphdr);
>  	struct dst_entry *dst;
>  	__be32 *topt;
> +	struct ipv6_pinfo *np = inet6_sk(ctl_sk);
>  
> +	np->autoflowlabel = ip6_default_np_autolabel(net);

Please put the 'np' variable declaration a few lines up in order to preserve
the reverse christmas tree ordering of local variables (longest to
shortest line).

THank you.