netdev - RE: [PATCH v3 net-next 3/6] net: Add SW fallback infrastructure for offloaded sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM4PR0501MB2723B8CB65C0603F06DA11E2D40F0@AM4PR0501MB2723.eurprd05.prod.outlook.com>
Date:   Tue, 19 Dec 2017 19:15:44 +0000
From:   Ilya Lesokhin <ilyal@...lanox.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "davejwatson@...com" <davejwatson@...com>,
        "tom@...bertland.com" <tom@...bertland.com>,
        "hannes@...essinduktion.org" <hannes@...essinduktion.org>,
        Boris Pismenny <borisp@...lanox.com>,
        "Aviad Yehezkel" <aviadye@...lanox.com>,
        Liran Liss <liranl@...lanox.com>
Subject: RE: [PATCH v3 net-next 3/6] net: Add SW fallback infrastructure for
 offloaded sockets

> > diff --git a/net/core/dev.c b/net/core/dev.c
> > index b0eee49a2489..6a78d9046674 100644
> > --- a/net/core/dev.c
> > +++ b/net/core/dev.c
> > @@ -3051,6 +3051,10 @@ static struct sk_buff *validate_xmit_skb(struct
> sk_buff *skb, struct net_device
> >  	if (unlikely(!skb))
> >  		goto out_null;
> >
> > +	skb = skb_offload_check(skb, dev);
> > +	if (!skb)
> > +		goto out_null;
> > +
> >  	if (netif_needs_gso(skb, features)) {
> >  		struct sk_buff *segs;
> >
> 
> How is it going to work with stacked devices (bonding, team, tunnels) ?
> 

Currently we don't support TLS offload on stacked devices.
Note however that in that case the TLS layer will refuse to use device offload
And we will not go through this software offload path.