netdev - Re: [oss-drivers] [PATCH net 0/2] cls_bpf: fix offload state tracking with block callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c05df04c-f0b2-66ba-a170-aee24fe1e596@netronome.com>
Date:   Wed, 20 Dec 2017 11:33:55 +0000
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        netdev@...r.kernel.org
Cc:     daniel@...earbox.net, jiri@...nulli.us, oss-drivers@...ronome.com
Subject: Re: [oss-drivers] [PATCH net 0/2] cls_bpf: fix offload state tracking
 with block callbacks

2017-12-19 13:32 UTC-0800 ~ Jakub Kicinski <jakub.kicinski@...ronome.com>
> Hi!
>
> After introduction of block callbacks classifiers can no longer track
> offload state.  cls_bpf used to do that in an attempt to move common
> code from drivers to the core.  Remove that functionality and fix
> drivers.
>
> The user-visible bug this is fixing is that trying to offload a second
> filter would trigger a spurious DESTROY and in turn disable the already
> installed one.
>
>
> Jakub Kicinski (2):
>   cls_bpf: fix offload assumptions after callback conversion
>   nfp: bpf: keep track of the offloaded program
>
>  drivers/net/ethernet/netronome/nfp/bpf/main.c | 55 ++++++++++++----
>  drivers/net/ethernet/netronome/nfp/bpf/main.h |  8 +++
>  include/net/pkt_cls.h                         |  5 +-
>  net/sched/cls_bpf.c                           | 93 +++++++++++----------------
>  4 files changed, 92 insertions(+), 69 deletions(-)
>

Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>