netdev - Re: [PATCH net 1/2] cls_bpf: fix offload assumptions after callback conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171220060539.GA1916@nanopsycho>
Date:   Wed, 20 Dec 2017 07:05:39 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, daniel@...earbox.net,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net 1/2] cls_bpf: fix offload assumptions after callback
 conversion

Tue, Dec 19, 2017 at 10:32:13PM CET, jakub.kicinski@...ronome.com wrote:
>cls_bpf used to take care of tracking what offload state a filter
>is in, i.e. it would track if offload request succeeded or not.
>This information would then be used to issue correct requests to
>the driver, e.g. requests for statistics only on offloaded filters,
>removing only filters which were offloaded, using add instead of
>replace if previous filter was not added etc.
>
>This tracking of offload state no longer functions with the new
>callback infrastructure.  There could be multiple entities trying
>to offload the same filter.
>
>Throw out all the tracking and corresponding commands and simply
>pass to the drivers both old and new bpf program.  Drivers will
>have to deal with offload state tracking by themselves.
>
>Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload")
>Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>

Thanks Jakub!