netdev - Re: [PATCH net] l2tp: fix missing print session offset info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171221.150836.1128769335522894244.davem@davemloft.net>
Date:   Thu, 21 Dec 2017 15:08:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH net] l2tp: fix missing print session offset info

From: Hangbin Liu <liuhangbin@...il.com>
Date: Thu, 21 Dec 2017 14:45:30 +0800

> +	    (session->offset &&
> +	     nla_put_u16(skb, L2TP_ATTR_OFFSET, session->offset) ||

It really discourages people from reviewing your changes when they
don't even compile.

net/l2tp/l2tp_netlink.c: In function ‘l2tp_nl_session_send’:
net/l2tp/l2tp_netlink.c:764:23: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
      (session->offset &&
       ~~~~~~~~~~~~~~~~^~
       nla_put_u16(skb, L2TP_ATTR_OFFSET, session->offset) ||
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/l2tp/l2tp_netlink.c:782:3: error: expected ‘)’ before ‘goto’
   goto nla_put_failure;
   ^~~~
 ...