netdev - Re: [PATCH net] l2tp: fix missing print session offset info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171222032903.GD13972@leo.usersys.redhat.com>
Date:   Fri, 22 Dec 2017 11:29:03 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH net] l2tp: fix missing print session offset info

On Thu, Dec 21, 2017 at 03:08:36PM -0500, David Miller wrote:
> From: Hangbin Liu <liuhangbin@...il.com>
> Date: Thu, 21 Dec 2017 14:45:30 +0800
> 
> > +	    (session->offset &&
> > +	     nla_put_u16(skb, L2TP_ATTR_OFFSET, session->offset) ||
> 
> It really discourages people from reviewing your changes when they
> don't even compile.

Sh*t, I did compile and test my patch on the compiler. But forgot to the fix the
code on my laptop...Really sorry for this, I need to double check it before
send.