netdev - Re: [PATCH iproute2 0/2] ip/tunnel: Do not free() answer on rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171226090845.0d69d42f@xeon-e3>
Date:   Tue, 26 Dec 2017 09:08:45 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Serhey Popovych <serhe.popovych@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 0/2] ip/tunnel: Do not free() answer on
 rtnl_talk() error, correct ip6gre

On Wed, 20 Dec 2017 09:57:08 +0200
Serhey Popovych <serhe.popovych@...il.com> wrote:

> In this series I present next set of improvements/fixes:
> 
>   1) If rtnl_talk(), called with answer != NULL fails it
>      never returns with allocated answer: no need to
>      initialize answer and free() it in the caller on error.
> 
>   2) Correct ip6gre print endpoint address printing with
>      ll_addr_n2a(): endpoints are IPv6 addresses, not hex
>      dump.
> 
> See individual patch description message for details.
> 
> Thanks,
> Serhii
> 
> Serhey Popovych (2):
>   utils: ll_addr: Handle ARPHRD_IP6GRE in ll_addr_n2a()
>   ip/tunnel: No need to free answer after rtnl_talk() on error
> 
>  ip/link_gre.c    |    3 +--
>  ip/link_gre6.c   |    3 +--
>  ip/link_ip6tnl.c |    3 +--
>  ip/link_iptnl.c  |    3 +--
>  ip/link_vti.c    |    3 +--
>  ip/link_vti6.c   |    3 +--
>  lib/ll_addr.c    |    3 ++-
>  7 files changed, 8 insertions(+), 13 deletions(-)
> 

Applied, thanks.