netdev - Re: [net 02/14] Revert "mlx5: move affinity hints assignments to generic code"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95a5c181-79fa-da60-1c94-766e19e97dd3@grimberg.me>
Date:   Tue, 26 Dec 2017 19:14:35 +0200
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Saeed Mahameed <saeedm@....mellanox.co.il>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jes Sorensen <jsorensen@...com>
Subject: Re: [net 02/14] Revert "mlx5: move affinity hints assignments to
 generic code"


> Are you sure it won't get populated at all  ? even if you manually set
> IRQ affinity via sysfs ?

Yes, the msi_desc affinity is not initialized without the affinity
descriptor passed (which is what PCI_IRQ_AFFINITY is for).

> Anyway we can implement this driver helper function to return the IRQ
> affinity hint stored in the driver:
>   "cpumask_first(mdev->priv.irq_info[vector].mask);"

minus the cpumask_first, but yea. Please send a new patch so we can
test it out.