netdev - Re: [Patch net] net_sched: fix a missing rcu barrier in mini_qdisc_pair

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171226.123021.1477766854322698861.davem@davemloft.net>
Date:   Tue, 26 Dec 2017 12:30:21 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, john.fastabend@...il.com
Subject: Re: [Patch net] net_sched: fix a missing rcu barrier in
 mini_qdisc_pair_swap()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Wed, 20 Dec 2017 23:26:24 -0800

> The rcu_barrier_bh() in mini_qdisc_pair_swap() is to wait for
> flying RCU callback installed by a previous mini_qdisc_pair_swap(),
> however we miss it on the tp_head==NULL path, which leads to that
> the RCU callback still uses miniq_old->rcu after it is freed together
> with qdisc in qdisc_graft(). So just add it on that path too.
> 
> Fixes: 46209401f8f6 ("net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath ")
> Reported-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Tested-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Cc: Jiri Pirko <jiri@...lanox.com>
> Cc: John Fastabend <john.fastabend@...il.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied.