netdev - Re: [PATCH net-next] rtnetlink: Replace implementation of ASSERT_RTNL() macro with WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Dec 2017 12:30:31 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     leon@...nel.org
Cc:     leonro@...lanox.com, markb@...lanox.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] rtnetlink: Replace implementation of
 ASSERT_RTNL() macro with WARN_ONCE()

From: Leon Romanovsky <leon@...nel.org>
Date: Thu, 21 Dec 2017 11:40:04 +0200

> From: Leon Romanovsky <leonro@...lanox.com>
> 
> ASSERT_RTNL() macro is actual open-coded variant of WARN_ONCE() with
> two exceptions. First, it prints stack for multiple hits and not only
> once as WARN_ONCE() does. Second, the user can disable prints of
> WARN_ONCE by setting CONFIG_BUG to N.
> 
> The multiple prints of dump stack are actually not needed, because calls
> without rtnl lock are programming errors and user can't do anything
> about them except to complain to the mailing list after first occurrence
> of such failure.
> 
> The user who disabled BUG/WARN prints did it explicitly because by default
> in upstream kernel and distributions this option is enabled. It means
> that user doesn't want to see prints about missing locks too.
> 
> This patch replaces open-coded variant in favor of already existing
> macro and change error prints to be once only.
> 
> Reviewed-by: Mark Bloch <markb@...lanox.com>
> Signed-off-by: Leon Romanovsky <leonro@...lanox.com>

Applied.