netdev - Re: [PATCH iproute2 0/3] ip/tunnel: Fix noencap- and document "external" parameter handling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171227134712.12338c7c@xeon-e3>
Date:   Wed, 27 Dec 2017 13:47:12 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Serhey Popovych <serhe.popovych@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 0/3] ip/tunnel: Fix noencap- and document
 "external" parameter handling.

On Wed, 27 Dec 2017 13:28:13 +0200
Serhey Popovych <serhe.popovych@...il.com> wrote:

> In this series I present next set of improvements/fixes:
> 
>   1) Fix noencap- option handling: we need to clear bit, instead
>      of seting all, but one we expect to clear.
> 
>   2) Document "external" parameter both in ip-link(8) and help
>      output for link_gre.c. Add "noexternal" option variant to
>      bring inline with GENEVE and VXLAN.
> 
>   3) Trivial: clear flowlabel/tclass from flowinfo in case of
>      inherit to stop sending garbage to the kernel. It has no
>      functional change, but follows similar behaviour in link_ip6tnl.c
> 
> See individual patch description message for details.
> 
> Thanks,
> Serhii
> 
> Serhey Popovych (3):
>   gre,ip6tnl/tunnel: Fix noencap- support
>   gre6/tunnel: Do not submit garbage in flowinfo
>   ip/tunnel: Document "external" parameter
> 
>  ip/link_gre.c         |    7 +++++--
>  ip/link_gre6.c        |    4 ++--
>  ip/link_ip6tnl.c      |    6 ++++--
>  ip/link_iptnl.c       |    4 +++-
>  man/man8/ip-link.8.in |    6 ++++++
>  5 files changed, 20 insertions(+), 7 deletions(-)
> 

These are really disjoint. I applied the noencap and the flowinfo patch.
Agree with William that having noexternal which does nothing useful is of little value now.