netdev - Re: [PATCH iproute2 3/3] ip/tunnel: Document "external" parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALDO+SYuR8kiNiVEoBY9CLCtVnFwYmJNzOzKOx+BNC3eE1gXfw@mail.gmail.com>
Date:   Wed, 27 Dec 2017 07:45:37 -0800
From:   William Tu <u9012063@...il.com>
To:     Serhey Popovych <serhe.popovych@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2 3/3] ip/tunnel: Document "external" parameter

Hi Serhey,

On Wed, Dec 27, 2017 at 3:28 AM, Serhey Popovych
<serhe.popovych@...il.com> wrote:
> Also add "noexternal" variant to be inline
> with geneve and vxlan tunnel types.
>
> Signed-off-by: Serhey Popovych <serhe.popovych@...il.com>
> ---
>  ip/link_gre.c         |    3 +++
>  ip/link_ip6tnl.c      |    4 +++-
>  ip/link_iptnl.c       |    4 +++-
>  man/man8/ip-link.8.in |    6 ++++++
>  4 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/ip/link_gre.c b/ip/link_gre.c
> index 896bb19..b383061 100644
> --- a/ip/link_gre.c
> +++ b/ip/link_gre.c
> @@ -43,6 +43,7 @@ static void print_usage(FILE *f)
>                 "                            [ [no]encap-csum ]\n"
>                 "                            [ [no]encap-csum6 ]\n"
>                 "                            [ [no]encap-remcsum ]\n"
> +               "                            [ [no]external ]\n"
>                 "                            [ fwmark MARK ]\n"
>                 "                            [ erspan IDX ]\n"
>                 "\n"
> @@ -288,6 +289,8 @@ get_failed:
>                         encapflags &= ~TUNNEL_ENCAP_FLAG_REMCSUM;
>                 } else if (strcmp(*argv, "external") == 0) {
>                         metadata = 1;
> +               } else if (strcmp(*argv, "noexternal") == 0) {
> +                       metadata = 0;
>                 } else if (strcmp(*argv, "ignore-df") == 0) {
>                         ignore_df = 1;
>                 } else if (strcmp(*argv, "noignore-df") == 0) {

What's the use case of noexternal?
AFAIK, setting 'noexternal' to the existing external device won't
change it to noexternal.
And if the device is created first time, then the default is noexternal.

William