netdev - Re: [PATCH V2 net-next] selftests/net: fix bugs in address and port initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180102.132718.1419274108075280136.davem@davemloft.net>
Date:   Tue, 02 Jan 2018 13:27:18 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sowmini.varadhan@...cle.com
Cc:     netdev@...r.kernel.org, willemdebruijn.kernel@...il.com,
        willemb@...gle.com
Subject: Re: [PATCH V2 net-next] selftests/net: fix bugs in address and
 port initialization

From: Sowmini Varadhan <sowmini.varadhan@...cle.com>
Date: Mon, 25 Dec 2017 14:43:04 -0800

> Address/port initialization should work correctly regardless
> of the order in which command line arguments are supplied,
> E.g, cfg_port should be used to connect to the remote host
> even if it is processed after -D, src/dst address initialization
> should not require that [-4|-6] be specified before
> the -S or -D args, receiver should be able to bind to *.<cfg_port>
> 
> Achieve this by making sure that the address/port structures
> are initialized after all command line options are parsed.
> 
> Store cfg_port in host-byte order, and use htons()
> to set up the sin_port/sin6_port before bind/connect,
> so that the network system calls get the correct values
> in network-byte order.
> 
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>

Applied, thank you.