netdev - Re: [PATCH net] net/sched: Fix update of lastuse in act modules implementing stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180102.132854.1445910631179933564.davem@davemloft.net>
Date:   Tue, 02 Jan 2018 13:28:54 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     roid@...lanox.com
Cc:     netdev@...r.kernel.org, paulb@...lanox.com, jiri@...lanox.com,
        xiyou.wangcong@...il.com, jhs@...atatu.com, ogerlitz@...lanox.com
Subject: Re: [PATCH net] net/sched: Fix update of lastuse in act modules
 implementing stats_update

From: Roi Dayan <roid@...lanox.com>
Date: Tue, 26 Dec 2017 07:48:51 +0200

> We need to update lastuse to to the most updated value between what
> is already set and the new value.
> If HW matching fails, i.e. because of an issue, the stats are not updated
> but it could be that software did match and updated lastuse.
> 
> Fixes: 5712bf9c5c30 ("net/sched: act_mirred: Use passed lastuse argument")
> Fixes: 9fea47d93bcc ("net/sched: act_gact: Update statistics when offloaded to hardware")
> Signed-off-by: Roi Dayan <roid@...lanox.com>
> Reviewed-by: Paul Blakey <paulb@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>

Applied and queued up for -stable.