netdev - Re: [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd76556945c563980a72009f9c86a13@codeaurora.org>
Date:   Wed, 03 Jan 2018 15:45:29 -0700
From:   Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, lkp@...el.com
Subject: Re: [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate

>> +	sk_pacing_shift_update(skb->sk, 8);
> 
> Well... Please tell us why this is needed in this driver.
> 
> This interface is meant for wifi aggregation, not to work around some
> strange ethernet drivers designs.

Hi Eric

The real device over which the rmnet devices are installed also
aggregate multiple IP packets and sends them as a single large aggregate
frame to the hardware.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project