netdev - Re: [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1515016918.131759.2.camel@gmail.com>
Date:   Wed, 03 Jan 2018 14:01:58 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>,
        davem@...emloft.net, netdev@...r.kernel.org, lkp@...el.com
Subject: Re: [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate

On Wed, 2018-01-03 at 14:43 -0700, Subash Abhinov Kasiviswanathan
wrote:
> With a default pacing rate of 10, the uplink data rate for a single
> TCP stream is around 10Mbps. Setting it to 8 increases it to 146Mbps
> which is the maximum supported transmit rate.
> 
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
> ---
>  drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c
> index 8e1f43a..8f8c4f2 100644
> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c
> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c
> @@ -16,6 +16,7 @@
>  #include <linux/netdevice.h>
>  #include <linux/netdev_features.h>
>  #include <linux/if_arp.h>
> +#include <net/sock.h>
>  #include "rmnet_private.h"
>  #include "rmnet_config.h"
>  #include "rmnet_vnd.h"
> @@ -204,6 +205,8 @@ void rmnet_egress_handler(struct sk_buff *skb)
>  	struct rmnet_priv *priv;
>  	u8 mux_id;
>  
> +	sk_pacing_shift_update(skb->sk, 8);

Well... Please tell us why this is needed in this driver.

This interface is meant for wifi aggregation, not to work around some
strange ethernet drivers designs.