netdev - Re: bonding: Delete an error message for a failed memory allocation in bond_update_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1515016712.131759.0.camel@gmail.com>
Date:   Wed, 03 Jan 2018 13:58:32 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Mahesh Bandewar
         (महेश बंडेवार) <maheshb@...gle.com>,
        SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-netdev <netdev@...r.kernel.org>,
        Andy Gospodarek <andy@...yhouse.net>,
        Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: bonding: Delete an error message for a failed memory allocation
 in bond_update_slave_arr()

On Wed, 2018-01-03 at 11:28 -0800, Mahesh Bandewar (महेश बंडेवार)
wrote:
> On Wed, Jan 3, 2018 at 12:45 AM, SF Markus Elfring
> <elfring@...rs.sourceforge.net> wrote:
> > > > Omit an extra message for a memory allocation failure in this function.
> > > > 
> > > > This issue was detected by using the Coccinelle software.
> > > > 
> > > 
> > > What is the issue with this message?
> > 
> > * Is it redundant?
> > 
> > * Would a Linux allocation failure report be already sufficient here?
> > 
> 
> If you see 8 out of 9 call sites in this file ignore the return value.
> This message in the log could give a clue when debugging. Unless it's
> spamming it's not harmful, or is it?

A failed kzalloc() would already give a complete stack trace.

Really the pr_err() adds no value here.