netdev - Re: [PATCH net-next v2 09/10] bnxt_en: add support for software dynamic interrupt moderation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180108140458.GA87664@C02RW35GFVH8.dhcp.broadcom.net>
Date:   Mon, 8 Jan 2018 09:04:58 -0500
From:   Andy Gospodarek <andy@...yhouse.net>
To:     Vasundhara Volam <vasundhara-v.volam@...adcom.com>
Cc:     netdev@...r.kernel.org, mchan@...adcom.com, talgi@...lanox.com,
        ogerlitz@...lanox.com, Andy Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next v2 09/10] bnxt_en: add support for software
 dynamic interrupt moderation

On Mon, Jan 08, 2018 at 04:20:04PM +0530, Vasundhara Volam wrote:
> Hi Andy,
> 
> If you are re-doing the patch, could you modify a minor comment below?
> 
> On Sat, Jan 6, 2018 at 4:28 AM, Andy Gospodarek <andy@...yhouse.net> wrote:
> 
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c
> > new file mode 100644
> > index 0000000..156e025
> > --- /dev/null
> > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c
> > @@ -0,0 +1,32 @@
> > +/*
> > + * Copyright (c) 2017 Broadcom Limited
> You have to modify year here.
> Also, First line driver description is missing "Broadcom NetXtreme-C/E
> network driver."
> Could you modify it?

Sure I could make those changes since it looks like I need a v3 anyway.
Thanks for the review.