netdev - Re: Subject: [RFC][PATCH 04/11] stmmac: fix breakage in stmmac_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180108.210235.1778522203071115101.davem@davemloft.net>
Date:   Mon, 08 Jan 2018 21:02:35 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     viro@....linux.org.uk
Cc:     netdev@...r.kernel.org, peppe.cavallaro@...com,
        Cavallaro@....linux.org.uk, Giuseppe@....linux.org.uk
Subject: Re: Subject: [RFC][PATCH 04/11] stmmac: fix breakage in
 stmmac_hw_setup()

From: Al Viro <viro@....linux.org.uk>
Date: Fri, 05 Jan 2018 19:31:58 +0000

> Since "drivers: net: stmmac: reworking the PCS code" ->pcs_ctrl_ane()
> had been taking iomem address to access as the first argument; its
> predecessor (->ctrl_ane()) used to take struct mac_device_info instead.
> 
> One of the callers had not been converted; as the result, instead of
> reading and modifying a word in card iomem we read and modify a word
> in (or near) the in-core strucct mac_device_info.
> 
> Fixes: 70523e639bf8 (drivers: net: stmmac: reworking the PCS code)
> Cc: stable@...r.kernel.org
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Yikes...

Al, can you split the bug fixes like this one into a separate series
for me to pull into my net GIT tree?

Don't include the pure annotation or partial endianness conversion
ones, those should go to net-next.