netdev - Re: Subject: [RFC][PATCH 04/11] stmmac: fix breakage in stmmac_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD5ja61Va8sj72xD6dEvXrdy36gb6baEQq8JK6kFRSVy5N9H8Q@mail.gmail.com>
Date:   Thu, 25 Jan 2018 09:21:37 +0100
From:   Niklas Cassel <nks.gnu@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     viro@....linux.org.uk, netdev@...r.kernel.org,
        peppe.cavallaro@...com, Cavallaro@....linux.org.uk,
        Giuseppe@....linux.org.uk
Subject: Re: Subject: [RFC][PATCH 04/11] stmmac: fix breakage in stmmac_hw_setup()

On Tue, Jan 9, 2018 at 3:02 AM, David Miller <davem@...emloft.net> wrote:
> From: Al Viro <viro@....linux.org.uk>
> Date: Fri, 05 Jan 2018 19:31:58 +0000
>
>> Since "drivers: net: stmmac: reworking the PCS code" ->pcs_ctrl_ane()
>> had been taking iomem address to access as the first argument; its
>> predecessor (->ctrl_ane()) used to take struct mac_device_info instead.
>>
>> One of the callers had not been converted; as the result, instead of
>> reading and modifying a word in card iomem we read and modify a word
>> in (or near) the in-core strucct mac_device_info.
>>
>> Fixes: 70523e639bf8 (drivers: net: stmmac: reworking the PCS code)
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
>
> Yikes...
>
> Al, can you split the bug fixes like this one into a separate series
> for me to pull into my net GIT tree?

This looks like a nasty bug,
I haven't seen a resubmission of this.
Would be a shame if it just went forgotten.

Regards,
Niklas