netdev - Re: [PATCH net-next v2 1/6] net: Fix netdev_WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180108.220541.1359488060683672177.davem@davemloft.net>
Date:   Mon, 08 Jan 2018 22:05:41 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     joe@...ches.com
Cc:     galp@...lanox.com, netdev@...r.kernel.org, tariqt@...lanox.com,
        saeedm@...lanox.com
Subject: Re: [PATCH net-next v2 1/6] net: Fix netdev_WARN_ONCE macro

From: Joe Perches <joe@...ches.com>
Date: Mon, 08 Jan 2018 18:42:01 -0800

> On Sun, 2018-01-07 at 12:08 +0200, Gal Pressman wrote:
>> netdev_WARN_ONCE is broken (whoops..), this fix will remove the
>> unnecessary "condition" parameter, add the missing comma and change
>> "arg" to "args".
>> 
>> Fixes: 375ef2b1f0d0 ("net: Introduce netdev_*_once functions")
>> Signed-off-by: Gal Pressman <galp@...lanox.com>
>> Reviewed-by: Saeed Mahameed <saeedm@...lanox.com>
>> ---
>>  include/linux/netdevice.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index 352066e..5ff1ef9 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -4407,8 +4407,8 @@ do {								\
>>  	WARN(1, "netdevice: %s%s\n" format, netdev_name(dev),	\
>>  	     netdev_reg_state(dev), ##args)
>>  
>> -#define netdev_WARN_ONCE(dev, condition, format, arg...)		\
>> -	WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev)	\
>> +#define netdev_WARN_ONCE(dev, format, args...)				\
>> +	WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev),	\
> 
> You sure you want the newline before the format?

Hmmm, Gal please send me a relative fix for this.