netdev - Re: [PATCH net-next 2/2] openvswitch: add erspan version II support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOrHB_BaWpT5ZJPd+rJ1NGV0_hd5LDHqFoSvdTcrp_q2ZUfk7w@mail.gmail.com>
Date:   Tue, 9 Jan 2018 13:59:02 -0800
From:   Pravin Shelar <pshelar@....org>
To:     William Tu <u9012063@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] openvswitch: add erspan version II support

On Tue, Jan 9, 2018 at 7:17 AM, William Tu <u9012063@...il.com> wrote:
> On Mon, Jan 8, 2018 at 4:03 PM, Pravin Shelar <pshelar@....org> wrote:
>> On Fri, Jan 5, 2018 at 2:29 PM, William Tu <u9012063@...il.com> wrote:
>>> The patch adds support for configuring the erspan version II
>>> fields for openvswitch.
>>>
>> The patch looks good, But it could change userspace API for
>> OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS, how are we going to handle
>> compatibility?
>>
> Thanks.
> Yes, it will break the previous API, which uses
> OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS only to store 32-bit erspan index.
> Should I create another tunnel key attr?
> Something like:
> -       OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS,        /* be32 ERSPAN index. */
> +       OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTSV1,        /* compatibility for
> erspan v1, be32 ERSPAN index. */
> +       OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTSV2,        /* supporting both
> v1 and v2 using Nested OVS_ERSPAN_OPT_* */
>

Sounds good, you could deprecate the V1 if v2 can handle both cases.