netdev - Re: [PATCH net-next v4 00/10] net: create dynamic software irq moderation library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38279ccb-0cf0-0365-9611-0cde1cc809cd@mellanox.com>
Date:   Tue, 9 Jan 2018 23:55:02 +0200
From:   Tal Gilboa <talgi@...lanox.com>
To:     Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org
Cc:     mchan@...adcom.com, ogerlitz@...lanox.com,
        Andy Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next v4 00/10] net: create dynamic software irq
 moderation library

On 1/9/2018 11:06 PM, Andy Gospodarek wrote:
> From: Andy Gospodarek <gospo@...adcom.com>
> 
> This converts the dynamic interrupt moderation library from the mlx5e
> driver into a library so it can be used by any driver.  The penultimate
> patch in this set adds support for this new dynamic interrupt moderation
> library in the bnxt_en driver and the last patch creates an entry in the
> MAINTAINERS file for this library.
> 
> The main purpose of this code is to allow an administrator to make sure
> that default coalesce settings are optimized for low latency, but
> quickly adapt to handle high throughput/bulk traffic by altering how
> much time passes before popping an interrupt.
> 
> For any new driver the following changes would be needed to use this
> library:
> 
> - add elements in ring struct to track items needed by this library
> - create function that can be called to actually set coalesce settings
>    for the driver
> 
> Credit to Rob Rice and Lee Reed for doing some of the initial proof of
> concept and testing for this patch and Tal Gilboa and Or Gerlitz for
> their comments, etc on this set.
> 
> v4: Fix build breakage for VF representers noticed by kbuild test robot.
> Thanks for being so courteous, kbuild test robot!
> 
> v3: bnxt_en fix from Michael Chan, comment suggestion from Vasundhara
> Volam, and small mlx5e header file fix from Tal Gilboa.
> 
> v2: Spelling fixes from Stephen Hemminger, bnxt_en suggestions from
> Michael Chan, spelling and formatting fixes from Or Gerlitz, and
> spelling and mlx5e changes suggested by Tal Gilboa.
> 
> Andy Gospodarek (10):
>    net/mlx5e: Move interrupt moderation structs to new file
>    net/mlx5e: Move interrupt moderation forward declarations
>    net/mlx5e: Remove rq references in mlx5e_rx_am
>    net/mlx5e: Move AM logic enums
>    net/mlx5e: Move generic functions to new file
>    net/mlx5e: Change Mellanox references in DIM code
>    net/mlx5e: Move dynamic interrupt coalescing code to include/linux
>    net/dim: use struct net_dim_sample as arg to net_dim
>    bnxt_en: add support for software dynamic interrupt moderation
>    MAINTAINERS: add entry for Dynamic Interrupt Moderation
> 
>   MAINTAINERS                                        |   5 +
>   drivers/net/ethernet/broadcom/bnxt/Makefile        |   2 +-
>   drivers/net/ethernet/broadcom/bnxt/bnxt.c          |  50 +++
>   drivers/net/ethernet/broadcom/bnxt/bnxt.h          |  34 +-
>   drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c      |  33 ++
>   drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c  |  12 +
>   drivers/net/ethernet/mellanox/mlx5/core/Makefile   |   2 +-
>   drivers/net/ethernet/mellanox/mlx5/core/en.h       |  46 +--
>   drivers/net/ethernet/mellanox/mlx5/core/en_dim.c   |  49 +++
>   .../net/ethernet/mellanox/mlx5/core/en_ethtool.c   |   6 +-
>   drivers/net/ethernet/mellanox/mlx5/core/en_main.c  |  40 ++-
>   drivers/net/ethernet/mellanox/mlx5/core/en_rep.c   |   2 +-
>   drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c | 341 -------------------
>   drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c  |  10 +-
>   include/linux/net_dim.h                            | 373 +++++++++++++++++++++
>   15 files changed, 594 insertions(+), 411 deletions(-)
>   create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c
>   create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_dim.c
>   delete mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c
>   create mode 100644 include/linux/net_dim.h
> 

+1. Great work Andy!