netdev - Re: [PATCH net-next v4 00/10] net: create dynamic software irq moderation library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7cfb332-49fd-a8a1-8943-f59f5a5678a8@gmail.com>
Date:   Tue, 9 Jan 2018 14:46:50 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org
Cc:     mchan@...adcom.com, talgi@...lanox.com, ogerlitz@...lanox.com,
        Andy Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next v4 00/10] net: create dynamic software irq
 moderation library

Hey Andy,

On 01/09/2018 01:06 PM, Andy Gospodarek wrote:
> From: Andy Gospodarek <gospo@...adcom.com>
> 
> This converts the dynamic interrupt moderation library from the mlx5e
> driver into a library so it can be used by any driver.  The penultimate
> patch in this set adds support for this new dynamic interrupt moderation
> library in the bnxt_en driver and the last patch creates an entry in the
> MAINTAINERS file for this library.
> 
> The main purpose of this code is to allow an administrator to make sure
> that default coalesce settings are optimized for low latency, but
> quickly adapt to handle high throughput/bulk traffic by altering how
> much time passes before popping an interrupt.
> 
> For any new driver the following changes would be needed to use this
> library:
> 
> - add elements in ring struct to track items needed by this library
> - create function that can be called to actually set coalesce settings
>   for the driver
> 
> Credit to Rob Rice and Lee Reed for doing some of the initial proof of
> concept and testing for this patch and Tal Gilboa and Or Gerlitz for
> their comments, etc on this set.
> 
> v4: Fix build breakage for VF representers noticed by kbuild test robot.
> Thanks for being so courteous, kbuild test robot!
> 
> v3: bnxt_en fix from Michael Chan, comment suggestion from Vasundhara
> Volam, and small mlx5e header file fix from Tal Gilboa.
> 
> v2: Spelling fixes from Stephen Hemminger, bnxt_en suggestions from
> Michael Chan, spelling and formatting fixes from Or Gerlitz, and
> spelling and mlx5e changes suggested by Tal Gilboa.

Certainly not a blocking item for this patch series, but can you
consider a follow up patch adding a small bit of documentation entry
covering how the implementation works as well as possible
limitations/considerations depending on what the networking HW supports
in terms of interrupt moderation capabilities? (e.g: is it necessary to
support generating an interrupt on ring empty, a micro-second resolution
RX/TX timeout etc. etc.).

Thanks for doing this!
-- 
Florian