netdev - Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpVrONAywBu2p=kF1gkqzRvzgm+=ejcx3r76p1BuLH=FDg@mail.gmail.com>
Date:   Tue, 9 Jan 2018 14:47:26 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Vlad Yasevich <vyasevich@...il.com>,
        Ben Hutchings <ben.hutchings@...ethink.co.uk>
Subject: Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device

On Tue, Jan 9, 2018 at 2:30 PM, Nikolay Aleksandrov
<nikolay@...ulusnetworks.com> wrote:
>
> Just for reference - this is identical to the first part of:
> https://patchwork.ozlabs.org/patch/252891/
>
> I knew this looked familiar. :-)
>

Yeah, except bonding is not even involved. Unless I misread,
DaveM rejected it because of bond, which I never touch here.

The refcnt is paired in vlan_vid_{add,del}, and the calls are
paired in register/unreigster and NETDEV_UP/NETDEV_DOWN
after this patch.