netdev - Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73df52fd-0025-5cf3-bcb8-5ed8bd6438d3@cumulusnetworks.com>
Date:   Wed, 10 Jan 2018 00:53:22 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Vlad Yasevich <vyasevich@...il.com>,
        Ben Hutchings <ben.hutchings@...ethink.co.uk>
Subject: Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device

On 01/10/2018 12:47 AM, Cong Wang wrote:
> On Tue, Jan 9, 2018 at 2:30 PM, Nikolay Aleksandrov
> <nikolay@...ulusnetworks.com> wrote:
>>
>> Just for reference - this is identical to the first part of:
>> https://patchwork.ozlabs.org/patch/252891/
>>
>> I knew this looked familiar. :-)
>>
> 
> Yeah, except bonding is not even involved. Unless I misread,
> DaveM rejected it because of bond, which I never touch here.
> 
> The refcnt is paired in vlan_vid_{add,del}, and the calls are
> paired in register/unreigster and NETDEV_UP/NETDEV_DOWN
> after this patch.
> 

You should read all of my replies to Dave, specifically the last one where I
describe exactly a memory leak, and IIRC the rejection was not because of the
bonding part but exactly because of this change - the removal of the vlan_id
conditional.
I'm not arguing about this patch now, I've said what I had to say back then,
I just gave it as a reference in case there's still relevant information in
there.

Thanks,
 Nik