netdev - Re: [PATCH bpf-next 2/2] net: free RX queue structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180110115911.7a98d3e9@redhat.com>
Date:   Wed, 10 Jan 2018 11:59:11 +0100
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, daniel@...earbox.net,
        alexei.starovoitov@...il.com, oss-drivers@...ronome.com,
        brouer@...hat.com
Subject: Re: [PATCH bpf-next 2/2] net: free RX queue structures

On Wed, 10 Jan 2018 01:20:02 -0800
Jakub Kicinski <jakub.kicinski@...ronome.com> wrote:

> Looks like commit e817f85652c1 ("xdp: generic XDP handling of
> xdp_rxq_info") replaced kvfree(dev->_rx) in free_netdev() with
> a call to netif_free_rx_queues() which doesn't actually free
> the rings?
> 
> While at it remove the unnecessary temporary variable.
> 
> Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Simon Horman <simon.horman@...ronome.com>

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

Thanks for fixing this!

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer