netdev - Re: [PATCH bpf-next 1/2] net: use the right variant of kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180110115826.6793b1a6@redhat.com>
Date:   Wed, 10 Jan 2018 11:58:26 +0100
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, daniel@...earbox.net,
        alexei.starovoitov@...il.com, oss-drivers@...ronome.com,
        brouer@...hat.com
Subject: Re: [PATCH bpf-next 1/2] net: use the right variant of kfree

On Wed, 10 Jan 2018 01:20:01 -0800
Jakub Kicinski <jakub.kicinski@...ronome.com> wrote:

> kvzalloc'ed memory should be kvfree'd.
> 
> Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Simon Horman <simon.horman@...ronome.com>
> ---
>  net/core/dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index d7925ef8743d..852a54c769a3 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -7645,7 +7645,7 @@ static int netif_alloc_rx_queues(struct net_device *dev)
>  	/* Rollback successful reg's and free other resources */
>  	while (i--)
>  		xdp_rxq_info_unreg(&rx[i].xdp_rxq);
> -	kfree(dev->_rx);
> +	kvfree(dev->_rx);
>  	dev->_rx = NULL;
>  	return err;
>  }

Thanks for catching this!

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer