netdev - Re: [patch net-next 1/5] mlxsw: reg: add rdpm register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180111.134713.1077073454608674334.davem@davemloft.net>
Date:   Thu, 11 Jan 2018 13:47:13 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, nogahf@...lanox.com, yuvalm@...lanox.com,
        idosch@...lanox.com, mlxsw@...lanox.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com
Subject: Re: [patch net-next 1/5] mlxsw: reg: add rdpm register

From: Jiri Pirko <jiri@...nulli.us>
Date: Thu, 11 Jan 2018 11:20:58 +0100

> From: Yuval Mintz <yuvalm@...lanox.com>
> 
> Add rdpm definition - router DSCP to priority mapping register.
> 
> Signed-off-by: Yuval Mintz <yuvalm@...lanox.com>
> Signed-off-by: Nogah Frankel <nogahf@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

This doesn't explain why adding a definition for this register...

> @@ -42,7 +42,7 @@
>  
>  struct mlxsw_item {
>  	unsigned short	offset;		/* bytes in container */
> -	unsigned short	step;		/* step in bytes for indexed items */
> +	short		step;		/* step in bytes for indexed items */
>  	unsigned short	in_step_offset; /* offset within one step */
>  	unsigned char	shift;		/* shift in bits */
>  	unsigned char	element_size;	/* size of element in bit array */

requires making mlxsw_item->step signed.

Please update the commit message or move this change into a more
appropriate patch in this series or even a new one.  Whichever
is required.

Thanks.