netdev - Re: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180111152537.3a90c722@cakuba.netronome.com>
Date:   Thu, 11 Jan 2018 15:25:37 -0800
From:   Jakub Kicinski <kubakici@...pl>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, nogahf@...lanox.com, yuvalm@...lanox.com,
        davem@...emloft.net, idosch@...lanox.com, mlxsw@...lanox.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com
Subject: Re: [patch net-next 3/5] net: sch: prio: Add offload ability to
 PRIO qdisc

On Thu, 11 Jan 2018 11:21:00 +0100, Jiri Pirko wrote:
> +struct tc_prio_qopt_offload_params {
> +	int bands;
> +	u8 priomap[TC_PRIO_MAX + 1];
> +	/* In case that a prio qdisc is offloaded and now is changed to a
> +	 * non-offloadedable config, it needs to update the backlog value
> +	 * to negate the HW backlog value.
> +	 */
> +	u32 *backlog;
> +};

Could we please pass the full qstats on replace and destroy.  This
simplifies the driver code and allows handling the qlen as well as
backlog.  Please see the 2 patch series I sent earlier yesterday.