netdev - RE: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR05MB35206C809B87495A33F2C8CABF160@VI1PR05MB3520.eurprd05.prod.outlook.com>
Date:   Thu, 11 Jan 2018 23:50:27 +0000
From:   Yuval Mintz <yuvalm@...lanox.com>
To:     Jakub Kicinski <kubakici@...pl>, Jiri Pirko <jiri@...nulli.us>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Nogah Frankel <nogahf@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Ido Schimmel" <idosch@...lanox.com>, mlxsw <mlxsw@...lanox.com>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>
Subject: RE: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO
 qdisc

> > +struct tc_prio_qopt_offload_params {
> > +	int bands;
> > +	u8 priomap[TC_PRIO_MAX + 1];
> > +	/* In case that a prio qdisc is offloaded and now is changed to a
> > +	 * non-offloadedable config, it needs to update the backlog value
> > +	 * to negate the HW backlog value.
> > +	 */
> > +	u32 *backlog;
> > +};
> 
> Could we please pass the full qstats on replace and destroy.  This
> simplifies the driver code and allows handling the qlen as well as
> backlog.  Please see the 2 patch series I sent earlier yesterday.

That might give the false impression that offloading driver is expected
to correct all the qstats fields during destruction, whereas for most of
them it doesn't seem appropriate.