netdev - Re: [net-next PATCH 1/1] tipc: add back tipc prefix to log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180115.134339.3259388418166535.davem@davemloft.net>
Date:   Mon, 15 Jan 2018 13:43:39 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     thompa.atl@...il.com
Cc:     netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
        jon.maloy@...csson.com, ying.xue@...driver.com
Subject: Re: [net-next PATCH 1/1] tipc: add back tipc prefix to log messages

From: David Miller <davem@...emloft.net>
Date: Mon, 15 Jan 2018 13:42:45 -0500 (EST)

> From: John Thompson <thompa.atl@...il.com>
> Date: Wed, 10 Jan 2018 08:50:24 +1300
> 
>> The tipc prefix to log messages generated by tipc was
>> removed in commit 07f6c4bc0 ("tipc: convert tipc reference
>> table to use generic rhashtable").
>> 
>> This is still a useful prefix and so add it back.
>> 
>> Acked-by: Jon Maloy <jon.maloy@...csson.com>
>> Signed-off-by: John Thompson <thompa.atl@...il.com>
> 
> Applied, thank you.

Actually, this breaks the build, reverted:

In file included from net/tipc/addr.h:44:0,
                 from net/tipc/addr.c:38:
net/tipc/core.h:40:0: warning: "pr_fmt" redefined
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
In file included from ./include/linux/kernel.h:14:0,
                 from net/tipc/addr.c:37:
./include/linux/printk.h:285:0: note: this is the location of the previous definition
 #define pr_fmt(fmt) fmt